Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove plugins from lunchable #118

Merged
merged 2 commits into from
Jan 26, 2024
Merged

🐛 remove plugins from lunchable #118

merged 2 commits into from
Jan 26, 2024

Conversation

juftin
Copy link
Owner

@juftin juftin commented Jan 26, 2024

This PR removes plugins from the repo now that they are meant to be installed externally:

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (752f2a3) 89.93% compared to head (dedc4c1) 90.04%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   89.93%   90.04%   +0.10%     
==========================================
  Files          22       22              
  Lines         964      964              
  Branches       79       79              
==========================================
+ Hits          867      868       +1     
  Misses         81       81              
+ Partials       16       15       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juftin juftin force-pushed the fix/remove_plugins branch from 57c9d26 to dedc4c1 Compare January 26, 2024 03:24
@juftin juftin merged commit 177ff71 into main Jan 26, 2024
11 checks passed
@juftin juftin deleted the fix/remove_plugins branch January 26, 2024 03:34
@juftin
Copy link
Owner Author

juftin commented Jan 26, 2024

🎉 This PR is included in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@juftin
Copy link
Owner Author

juftin commented Jan 30, 2024

Hey @ebroder @ericzinnikas just want to give you both an FYI as you've previously contributed to the SplitLunch plugin.

All plugins have been moved into their own separate packages outside of the main lunchable repo:

They're all still accessible from the lunchable CLI as long as they're installed into the same environment as lunchable via a new plugin framework.

If you're interested in using these plugins the best way to install them is using the plugins extra (the splitlunch extra works too)

pipx install "lunchable[plugins]"

Accessing plugins from the command line is still the same as before:

lunchable plugins splitlunch ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant